lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Sep 2014 13:27:38 +0530 From: Vivek Gautam <gautam.vivek@...sung.com> To: Felipe Balbi <balbi@...com> Cc: Linux USB Mailing List <linux-usb@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>, Greg KH <gregkh@...uxfoundation.org>, kishon <kishon@...com>, Kukjin Kim <kgene.kim@...sung.com> Subject: Re: [PATCH 3/5] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply Hi Felipe, On Fri, Aug 29, 2014 at 12:46 AM, Felipe Balbi <balbi@...com> wrote: > hi, > > On Thu, Aug 28, 2014 at 01:31:58PM +0530, Vivek Gautam wrote: >> @@ -457,11 +458,19 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy) >> clk_prepare_enable(phy_drd->ref_clk); >> >> /* Enable VBUS supply */ >> + if (phy_drd->vbus_boost) { >> + ret = regulator_enable(phy_drd->vbus_boost); >> + if (ret) { >> + dev_err(phy_drd->dev, >> + "Failed to enable VBUS boost supply\n"); >> + goto fail_vbus; >> + } >> + } > > really this is nitpicking, but can you add a blank line here just make > my inner child happy ? :-) Sure will add an extra line here and similar instances of this change. > >> @@ -470,6 +479,9 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy) >> >> return 0; >> >> +fail_vbus_boost: >> + if (phy_drd->vbus_boost) >> + regulator_disable(phy_drd->vbus_boost); > > same here > > -- > balbi -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists