lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 1 Sep 2014 12:05:05 +0300
From:	Octavian Purdila <>
To:	Lee Jones <>
Cc:	Greg Kroah-Hartman <>,
	Linus Walleij <>,
	Alexandre Courbot <>,,
	Samuel Ortiz <>,
	Arnd Bergmann <>, Johan Hovold <>,, lkml <>,,,
	Daniel Baluta <>,
	Laurentiu Palcu <>
Subject: Re: [PATCH v2 1/3] mfd: add support for Diolan DLN-2 devices

On Mon, Sep 1, 2014 at 11:37 AM, Lee Jones <> wrote:
> On Sat, 30 Aug 2014, Octavian Purdila wrote:
>> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
>> Master Adapter DLN-2. Details about the device can be found here:
>> Information about the USB protocol can be found in the Programmer's
>> Reference Manual [1], see section 1.7.
>> Because the hardware has a single transmit endpoint and a single
>> receive endpoint the communication between the various DLN2 drivers
>> and the hardware will be muxed/demuxed by this driver.
>> Each DLN2 module will be identified by the handle field within the DLN2
>> message header. If a DLN2 module issues multiple commands in parallel
>> they will be identified by the echo counter field in the message header.
>> The DLN2 modules can use the dln2_transfer() function to issue a
>> command and wait for its response. They can also register a callback
>> that is going to be called when a specific event id is generated by
>> the device (e.g. GPIO interrupts). The device uses handle 0 for
>> sending events.
>> [1]
> MFD is not a dumping ground for misfit h/w.  Almost all of this code
> looks like it belongs in drivers/usb.  Please move it there.

Hi Lee,

We initially submitted this driver as a pure USB driver, with our own
module registration mechanism, but during the first round of reviews
people pointed out that a MFD driver is the better approach, and I
agree. I also see that there are already a couple of USB drivers
implemented as MFD drivers.

Do you see a better approach?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists