linux-kernel - Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140901095446.GF5122@mwanda>
Date:	Mon, 1 Sep 2014 12:54:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Miguel Oliveira <cmroliv@...il.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	Larry.Finger@...inger.net, linux-kernel@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote:
> > Same comments as the previous ones, please redo all of these patches.
> >
> Should all the alterations be in one big single patch, insted of small ones?

Your first version broke the build if we applied only the first patch.
That's not allowed.

Also the new rtw_sys_remove_one() function isn't called.  I was confused
by it as well.  It doesn't "remove one", it removes everything.

Do we need to support llseek?

How have you tested this?  Have you tested module unloading?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/