linux-kernel - Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMGgR5vActZ6Cnv4LCvj1YQSmP26qCc4rps7iPkNhuTvQoVTrg@mail.gmail.com>
Date:	Mon, 1 Sep 2014 13:55:52 +0200
From:	Miguel Oliveira <cmroliv@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	Larry.Finger@...inger.net, linux-kernel@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH 3/4] staging: rtl8188eu: osdep_intf.h and usb_intf.c

>> > Same comments as the previous ones, please redo all of these patches.
>> >
>> Should all the alterations be in one big single patch, insted of small ones?
>
> Your first version broke the build if we applied only the first patch.
> That's not allowed.
I now understand that, thank you.

> Also the new rtw_sys_remove_one() function isn't called.  I was confused
> by it as well.  It doesn't "remove one", it removes everything.
The function it's not new, I just converted it from the proc to
defugfs, It can be renamed.

> Do we need to support llseek?
Probably not... I'll check it.

> How have you tested this?  Have you tested module unloading?
Yes, I've tested it several times and unloaded without issues.

Thank you for your comments,
Best Regards,
Miguel Oliveira
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/