linux-kernel - Re: [PATCH v2] arm64: fix bug for reloading FPSIMD state after cpu power off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140901115640.GD24594@arm.com>
Date:	Mon, 1 Sep 2014 12:56:40 +0100
From:	Will Deacon <will.deacon@....com>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Leo Yan <leoy@...vell.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH v2] arm64: fix bug for reloading FPSIMD state after cpu
 power off

On Mon, Sep 01, 2014 at 10:34:28AM +0100, Catalin Marinas wrote:
> On Mon, Sep 01, 2014 at 04:09:51AM +0100, Leo Yan wrote:
> > Now arm64 defers reloading FPSIMD state, but this optimization also
> > introduces the bug after cpu resume back from low power mode.
> > 
> > The reason is after the cpu has been powered off, s/w need set the
> > cpu's fpsimd_last_state to NULL so that it will force to reload
> > FPSIMD state for the thread, otherwise there has the chance to meet
> > the condition for both the task's fpsimd_state.cpu field contains the
> > id of the current cpu, and the cpu's fpsimd_last_state per-cpu variable
> > points to the task's fpsimd_state, so finally kernel will skip to reload
> > the context during it return back to userland.
> > 
> > Signed-off-by: Leo Yan <leoy@...vell.com>
> 
> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
> 
> (and cc'ing Will to pick it up since he's handling the 3.17 release)

Cheers for the CC; applied to fixes/core (I'll push out once I've run the
regression tests).

I aim to tag that branch tonight if we don't get any more fixes today.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/