lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 01 Sep 2014 17:17:51 +0200
From:	Arnd Bergmann <>
Cc:	Hanjun Guo <>,
	Catalin Marinas <>,
	"Rafael J. Wysocki" <>,
	Mark Rutland <>,
	Olof Johansson <>,
	Grant Likely <>,
	Rob Herring <>,
	Robert Richter <>,
	Jason Cooper <>,
	Marc Zyngier <>,
	Liviu Dudau <>,
	Daniel Lezcano <>,
	Will Deacon <>,
	Robert Moore <>,,,
	Mark Brown <>,
	Randy Dunlap <>,
	Lv Zheng <>,
	Bjorn Helgaas <>,
Subject: Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI

On Monday 01 September 2014 23:06:00 Hanjun Guo wrote:
> +#ifdef CONFIG_ACPI
> +/* Configure some sensible defaults for ACPI mode */
> +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config,
> +                                   acpi_handle *ahandle)
> +{
> +       if (!ahandle)
> +               return -ENOSYS;
> +
> +       config->phy_interface = PHY_INTERFACE_MODE_MII;

Please remove the #ifdef and use 

	if (!IS_ENABLED(CONFIG_ACPI) || !ahandle)

to check for ACPI support. This should result in the same object code
in all cases, but give better compile-time coverage when ACPI is

Also, -ENOSYS is probably the wrong return value. I think you mean

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists