linux-kernel - Re: [RFC PATCH for Juno 2/2] tty: SBSA compatible UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140901152644.GC29327@sirena.org.uk>
Date:	Mon, 1 Sep 2014 16:26:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Hanjun Guo <hanjun.guo@...aro.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Mark Rutland <mark.rutland@....com>,
	Olof Johansson <olof@...om.net>,
	Grant Likely <grant.likely@...aro.org>,
	Graeme Gregory <graeme.gregory@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Sudeep Holla <Sudeep.Holla@....com>,
	Will Deacon <will.deacon@....com>,
	Jason Cooper <jason@...edaemon.net>,
	Marc Zyngier <marc.zyngier@....com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Robert Richter <rric@...nel.org>,
	Lv Zheng <lv.zheng@...el.com>,
	Robert Moore <robert.moore@...el.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Liviu Dudau <Liviu.Dudau@....com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Charles.Garcia-Tobin@....com, linux-acpi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linaro-acpi@...ts.linaro.org
Subject: Re: [RFC PATCH for Juno 2/2] tty: SBSA compatible UART

On Mon, Sep 01, 2014 at 11:06:01PM +0800, Hanjun Guo wrote:
> From: Graeme Gregory <graeme.gregory@...aro.org>
> 
> This is a subset of pl011 UART which does not supprt DMA or baud rate
> changing.
> 
> It is specified in the Server Base System Architecture document from
> ARM.

Is there any reason not to consider submitting this as a TTY driver now
- are there known problems other than the issues with ACPI in general
(I've not reviewed the code at all)?  The ACPI binding in this case
seems particularly safe since it's a purposely basic and unconfigurable
IP.

I guess we may want to consider handoff to the full pl011 driver at some
point but there's a bunch of stuff with clocks to worry about before
then.

> 
> Signed-off-by: Graeme Gregory <graeme.gregory@...aro.org>
> ---

Missing signoff here.

> +config SBSAUART_TTY
> +	tristate "SBSA UART TTY Driver"
> +	help
> +	  Console and system TTY driver for the SBSA UART which is defined
> +	  in the Server Base System Architecure document for ARM64 servers.
> +

depends on ARM || ARM64 || COMPILE_TEST?

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)