linux-kernel - Re: [PATCH 3/3] cpufreq: kirkwood: use the powersave multiplexer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPtuhThLdvRMRT0rdd692v6eepzq2J8wDX=DFDwJbuO5B6fMQw@mail.gmail.com>
Date:	Tue, 2 Sep 2014 15:00:17 -0700
From:	Mike Turquette <mturquette@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Patch Tracking <patches@...aro.org>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
Subject: Re: [PATCH 3/3] cpufreq: kirkwood: use the powersave multiplexer

On Mon, Sep 1, 2014 at 9:49 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> On 2 September 2014 00:17, Mike Turquette <mturquette@...aro.org> wrote:
>
>> @@ -150,7 +146,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev)
>>                 err = PTR_ERR(priv.powersave_clk);
>>                 goto out_ddr;
>>         }
>> -       clk_prepare(priv.powersave_clk);
>> +       clk_prepare_enable(priv.powersave_clk);
>
> Shouldn't this be done in a separate patch? Or is this really related?

It is related. Before this change powersave_clk was modeled as a gate.
The separate clk_enable/clk_disable operations were used to toggle the
mux. This patch does two things:

1) remove the old gate-style powersave_clk in the clock driver and
replace with the mux-style powersave_clk data
2) update the cpufreq driver to handle the mux properly

So the change you pointed out above is part of #2.

These two changes are coupled in one patch to prevent git bisect breakage.

>
>>
>>         of_node_put(np);
>>         np = NULL;
>
> Other than that: Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> Yeah, you can take it through clock tree..

Cool.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/