linux-kernel - Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1409031236450.3333@nanos>
Date:	Wed, 3 Sep 2014 12:38:43 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Xiubo Li <Li.Xiubo@...escale.com>
cc:	daniel.lezcano@...aro.org, dongsheng.wang@...escale.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource
 read API.

On Tue, 26 Aug 2014, Xiubo Li wrote:

> Since the Flextimer device will be implemented in BE mode on
> LS1 SoC, and in LE mode on Vybrid, LS2 SoCs, so here we need
> the endianness judgment before doing the mmio.

Brilliant. So for every clocksource read you take a conditional.
 
> @@ -238,7 +243,7 @@ static int __init ftm_clocksource_init(unsigned long freq)
>  	sched_clock_register(ftm_read_sched_clock, 16, freq / (1 << priv->ps));
>  	err = clocksource_mmio_init(priv->clksrc_base + FTM_CNT, "fsl-ftm",
>  				    freq / (1 << priv->ps), 300, 16,
> -				    clocksource_mmio_readl_up);
> +				    ftm_clocksource_read_up);

What's wrong with having endianess aware clocksource_mmio functions
and make the decision at init time?

Thanks

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/