linux-kernel - RE: [PATCH] mfd: da9052: Avoid setting read_flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A0337AB51374D@SW-EX-MBX01.diasemi.com>
Date:	Wed, 3 Sep 2014 10:50:15 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>,
	"Lee Jones" <lee.jones@...aro.org>, Axel Lin <axel.lin@...ics.com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>,
	Support Opensource <Support.Opensource@...semi.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mfd: da9052: Avoid setting read_flag_mask for
 da9052-i2c driver

On August 28, 2014 14:38, Adam Thomson wrote:

> On August 28, 2014 12:21, Lee Jones wrote:
> 
> > Steve, Adam,
> >
> > > Current code init regmap with &da9052_regmap_config for both da9052-spi and
> > > da9052-i2c drivers. da9052-spi sets the read_flag_mask.
> > > The same setting may be applied for da9052-i2c if da9052-spi driver is loaded
> > > first because they actually use the same regmap_config setting.
> > > Fix this issue by using a local variable for regmap_config in da9052-spi driver,
> > > so the settings in spi driver won't impact the settings in i2c driver.
> > > Also makes da9052_regmap_config const to avoid similar issue.
> > >
> > > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > > ---
> > > Hi Adam and Steve,
> > > Any chance to test this patch?
> >
> > ** Look here **
> 
> Lee, Axel,
> 
> This was on my to-do list but hadn't yet responded. Will try and find some time
> in the next week to see if we can verify this.

Hi Axel, Lee,

I don't think I'm going to have time to test this soon. In terms of the change it looks fine to me, although I don't think you can run both SPI and I2C at the same time for this driver (I tried a quick test to instantiate both and saw issues with regulator initialisation for the second instance). Anyway, here's my ack for the change.

Acked-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>