linux-kernel - Re: [PATCH] tty/serial: fix config dependencies for samsung serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Sep 2014 12:56:02 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Naveen Krishna Ch <naveenkrishna.ch@...il.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	linux-serial@...r.kernel.org,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	Pankaj Dubey <pankaj.dubey@...sung.com>
Subject: Re: [PATCH] tty/serial: fix config dependencies for samsung serial

On Wednesday 03 September 2014 13:51:56 Naveen Krishna Ch wrote:
> On 2 September 2014 21:16, Arnd Bergmann <arnd@...db.de> wrote:
> > On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote:
> >> Make the config symbols SERIAL_SAMSUNG_UARTS_4 and
> >> SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than
> >> PLAT_SAMSUNG.
> >
> > Please always describe why you are doing a change. This patch
> > seems really pointless.
> 
> The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are
> meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency
> rules were changed. I will repost this patch with better description.

My point is that the options are used by both the uart driver and
the platform code, e.g. for the purpose of PM debugging which can
be enabled even when the serial-samsung driver is turned off.

> >>  config SERIAL_SAMSUNG_UARTS_4
> >>         bool
> >> -       depends on PLAT_SAMSUNG
> >> +       depends on SERIAL_SAMSUNG
> >>         default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
> >>         help
> >>           Internal node for the common case of 4 Samsung compatible UARTs
> >>
> >>  config SERIAL_SAMSUNG_UARTS
> >>         int
> >> -       depends on PLAT_SAMSUNG
> >> +       depends on SERIAL_SAMSUNG
> >>         default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
> >>         default 3
> >>         help
> >>
> >
> > Have you checked that it still builds on all samsung platforms when
> > SERIAL_SAMSUNG is disabled? We have had build errors in this area
> > in the past.
> 
> Yes, it builds for other Samsung platforms.

Ok.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/