linux-kernel - Re: [PATCH v2] irqchip: exynos-combiner: Fix compilation error on ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140903115728.GJ30467@titan.lakedaemon.net>
Date:	Wed, 3 Sep 2014 07:57:28 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>
Cc:	linux-kernel@...r.kernel.org, naveenkrishna.ch@...il.com,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v2] irqchip: exynos-combiner: Fix compilation error on
 ARM64

On Wed, Sep 03, 2014 at 11:02:09AM +0530, Naveen Krishna Chatradhi wrote:
> The following compilation error occurs on 64-bit Exynos7 SoC:
> 
> drivers/irqchip/exynos-combiner.c: In function ‘combiner_irq_domain_map’:
> drivers/irqchip/exynos-combiner.c:162:2: error: implicit declaration of function ‘set_irq_flags’ [-Werror=implicit-function-declaration]
>   set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
>   ^
> drivers/irqchip/exynos-combiner.c:162:21: error: ‘IRQF_VALID’ undeclared (first use in this function)
>   set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
>                      ^
> drivers/irqchip/exynos-combiner.c:162:21: note: each undeclared identifier is reported only once for each function it appears in
> drivers/irqchip/exynos-combiner.c:162:34: error: ‘IRQF_PROBE’ undeclared (first use in this function)
>   set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
> 
> Fix the build error by including linux/interrupt.h.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Sudeep Holla <sudeep.holla@....com>
> ---
> Changes since v1:
> Used linux/interrupt.h instead of asm/hardirq.h
> 
>  drivers/irqchip/exynos-combiner.c |    1 +
>  1 file changed, 1 insertion(+)

Applied to irqchip/urgent

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/