linux-kernel - Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54070234.30201@mm-sol.com>
Date:	Wed, 03 Sep 2014 14:57:40 +0300
From:	Georgi Djakov <gdjakov@...sol.com>
To:	Stephen Boyd <sboyd@...eaurora.org>, Chris Ball <chris@...ntf.net>,
	Ulf Hansson <ulf.hansson@...aro.org>
CC:	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Asutosh Das <asutoshd@...eaurora.org>,
	Venkat Gopalakrishnan <venkatg@...eaurora.org>
Subject: Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

On 09/03/2014 02:58 AM, Stephen Boyd wrote:
> If we're tuning on a big-endian CPU we'll never determine we properly
> tuned the device because we compare the data we received from the
> controller with a table that assumes the CPU is little-endian.
> Change the table to be an array of bytes instead of 32-bit words
> so we can use memcmp() without needing to byte-swap every word
> depending on the endianess of the CPU.
> 
> Cc: Asutosh Das <asutoshd@...eaurora.org>
> Cc: Venkat Gopalakrishnan <venkatg@...eaurora.org>
> Cc: Georgi Djakov <gdjakov@...sol.com>
> Fixes: 415b5a75da43 "mmc: sdhci-msm: Add platform_execute_tuning implementation"
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---

Looks nice. Thanks!

Reviewed-by: Georgi Djakov <gdjakov@...sol.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/