linux-kernel - Re: [PATCH] ext4: Fixed styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvwVNTXw1uvzJaTyo6EQNgGWuAnGTi7s2+r3P+zF71zD3A@mail.gmail.com>
Date:	Sun, 7 Sep 2014 15:16:22 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Daniel Bomar <dbdaniel42@...il.com>
Cc:	"Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca,
	linux-ext4@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ext4: Fixed styling issues

On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar <dbdaniel42@...il.com> wrote:
> Fixed styling issues as reported by scripts/checkpatch.pl
>
> Signed-off-by: Daniel Bomar <dbdaniel42@...il.com>

Please don't run checkpatch.pl on in-kernel files.
The tool is designed to check patches, not files.
Such whitespace cleanups pollute the kernel history, i.e. such that
git blame returns false positives.

The purpose of --file is:
- Checking out-of-tree files (like existing drivers to be imported)
- One notable exception is drivers/staging/, you can run it on these files.

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/