linux-kernel - Re: [PATCH] ext4: Fixed styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140907154625.GA18274@infradead.org>
Date:	Sun, 7 Sep 2014 08:46:25 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	Daniel Bomar <dbdaniel42@...il.com>, Theodore Ts'o <tytso@....edu>,
	adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ext4: Fixed styling issues

On Sun, Sep 07, 2014 at 03:16:22PM +0200, Richard Weinberger wrote:
> On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar <dbdaniel42@...il.com> wrote:
> > Fixed styling issues as reported by scripts/checkpatch.pl
> >
> > Signed-off-by: Daniel Bomar <dbdaniel42@...il.com>
> 
> Please don't run checkpatch.pl on in-kernel files.

I don't think it's up to us to tell people what files they should run
patches on on..  That doesn't mean that pure style cleanup patches in an
area you don't understand are a good idea, so don't send them.  This is
different when you actually do a major overhaul of an area, in which
case I'd actually like to do a first pass of style cleanup and
refactoring before submitting the real work.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/