linux-kernel - Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of context imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C97001BC43954D438ACB059713BA5CDFC97127E0E1@USEA-EXCH7.na.uis.unisys.com>
Date:	Mon, 8 Sep 2014 10:57:08 -0500
From:	"Romer, Benjamin M" <Benjamin.Romer@...sys.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:	"Kershner, David A" <David.Kershner@...sys.com>,
	*S-Par-Maintainer <SParMaintainer@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of
 context imbalance

On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
> fixed sparse warning : context imbalance in 'pause_device' 
> 			unexpected unlock
> this patch will generate warning from checkpatch for 
> lines over 80 character , but since those are user-visible strings
> so it was not modified.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> 
> hi , can you please review the patch and see if the approach is correct.
> The functiion is still doing the same what it was doing , only the logic
> is changed. if the approach is ok, then i can send a patch to fix the
> other two similar warning in the file.

Hi Sudip,

I was able to successfully build and test your patch. The changes look
good to me too, so I think we should take this patch. :)

Thanks!
-- Ben

Signed-off-by: Benjamin Romer <benjamin.romer@...sys.com>
Tested-by: Benjamin Romer <benjamin.romer@...sys.com>