linux-kernel - Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140908212601.GB10550@drone.musicnaut.iki.fi>
Date:	Tue, 9 Sep 2014 00:26:01 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Nitin Kuppelur <nitinkuppelur@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void
 functions

Hi,

On Mon, Sep 08, 2014 at 12:33:47PM -0700, Greg KH wrote:
> On Mon, Sep 08, 2014 at 09:59:23PM +0300, Aaro Koskinen wrote:
> > On Mon, Sep 08, 2014 at 07:13:15PM +0200, Nitin Kuppelur wrote:
> > > This is a patch to the octeon-hcd.c file that fixes checkpatch.pl warning by removing return statement from void functions.
> > 
> > Please format line length to <= 76 characters in the commit log.
> > 
> > Maybe you could fix __cvmx_usb_perform_complete() as well?
> 
> What is wrong with it?  That should be in a separate patch...

There's "return;" at the end of void function. I thought the patch
was about that, however it seems checkpatch.pl does not seem
complain about that.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/