linux-kernel - Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Sep 2014 10:14:28 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Nitin Kuppelur <nitinkuppelur@...il.com>
Cc:	Aaro Koskinen <aaro.koskinen@....fi>, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: octeon-hcd: removed unwanted return from void
 functions

On Mon, Sep 08, 2014 at 09:09:14PM +0200, Nitin Kuppelur wrote:
> Hi Aaro,
> 
> Thanks for review. I will correct the commit log length and resend the patch.
> 
> About the __cvmx_usb_perform_complete():
> Here return statement has associated label. Due to which it will add
> compilation warning. So I am not handling this.

Just remove the label as well.  Do-nothing labels are a plague.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/