lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Sep 2014 15:37:39 -0700 From: Darren Hart <dvhart@...radead.org> To: Paul Bolle <pebolle@...cali.nl> Cc: Corentin Chary <corentin.chary@...il.com>, Frans Klaver <fransklaver@...il.com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Matthew Garrett <matthew.garrett@...ula.com>, Rafael Wysocki <rafael.j.wysocki@...el.com>, acpi4asus-user@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] eeepc-laptop: simplify parse_arg() On Wed, Sep 10, 2014 at 10:05:20PM +0200, Paul Bolle wrote: > parse_arg() has three possible return values: > -EINVAL if sscanf(), in short, fails; > zero if "count" is zero; and > "count" in all other cases > > But "count" will never be zero. See, parse_arg() is called by the > various store functions. And the callchain of these functions starts > with sysfs_kf_write(). And that function checks for a zero "count". So > we can stop checking for a zero "count", drop the "count" argument > entirely, and transform parse_arg() into a function that returns zero on > success or a negative error. That, in turn, allows to make those store > functions just return "count" on success. The net effect is that the > code becomes a bit easier to understand. > > While we're at it, let store_sys_acpi() return whatever error set_acpi() > returns instead of remapping it to EIO. > > A nice side effect is that this GCC warning is silenced too: > drivers/platform/x86/eeepc-laptop.c: In function ‘store_sys_acpi’: > drivers/platform/x86/eeepc-laptop.c:279:10: warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] > int rv, value; > > Which is, of course, the reason to have a look at parse_arg(). > > Signed-off-by: Paul Bolle <pebolle@...cali.nl> Queued, thanks Paul. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists