linux-kernel - [PATCH] rhashtable: remove duplicate comment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Sep 2014 17:10:19 +1000
From:	NeilBrown <neilb@...e.de>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: [PATCH] rhashtable: remove duplicate comment.



The second comment is identical to the earlier comment, just indented
a bit. This is confusing, so remove it.

Also expand that first comment to mention the splicing that happens.

Signed-off-by: NeilBrown <neilb@...e.de>

diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index a2c78810ebc1..8fd2f21d022a 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -309,15 +309,12 @@ int rhashtable_shrink(struct rhashtable *ht, gfp_t flags)
 
 	/* Link each bucket in the new table to the ﬁrst bucket
 	 * in the old table that contains entries which will hash
-	 * to the new bucket.
+	 * to the new bucket, and then splice in the second
+	 * bucket from the old table.
 	 */
 	for (i = 0; i < ntbl->size; i++) {
 		ntbl->buckets[i] = tbl->buckets[i];
 
-		/* Link each bucket in the new table to the ﬁrst bucket
-		 * in the old table that contains entries which will hash
-		 * to the new bucket.
-		 */
 		for (pprev = &ntbl->buckets[i]; *pprev != NULL;
 		     pprev = &rht_dereference(*pprev, ht)->next)
 			;

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)