linux-kernel - Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410422381.7023.15.camel@intel.com>
Date:	Thu, 11 Sep 2014 07:59:51 +0000
From:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:	"atull@...nsource.altera.com" <atull@...nsource.altera.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"Chen, Alvin" <alvin.chen@...el.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	"gnurou@...il.com" <gnurou@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"sebastian@...akpoint.cc" <sebastian@...akpoint.cc>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"dvhart@...ux.intel.com" <dvhart@...ux.intel.com>,
	"arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding
 to MFD driver

On Wed, 2014-09-10 at 14:11 -0500, atull wrote:

[]

> >  static int dwapb_gpio_probe(struct platform_device *pdev)
> >  {
> > +	int i;
> >  	struct resource *res;
> >  	struct dwapb_gpio *gpio;
> > -	struct device_node *np;
> >  	int err;
> > -	unsigned int offs = 0;
> > +	struct device *dev = &pdev->dev;
> > +	struct dwapb_platform_data *pdata = dev_get_platdata(dev);
> > +	bool is_pdata_alloc = !pdata;
> 
> Please combine the int's in one line (int err, i;) and put them as
> the last one on this list.  It looks the same to the compiler of
> course, but more uniform for human eyes :)

Do you think it's a good idea? In this case I, for example, would like
to see int err as a separate line at the end of definition block. It
would be better to distinguish counters and return code storage.
Moreover, often counters would be unsigned int.

-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.