linux-kernel - RE: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Sep 2014 10:40:58 -0500
From:	atull <atull@...nsource.altera.com>
To:	"Chen, Alvin" <alvin.chen@...el.com>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: RE: [PATCH 1/4 v3] GPIO: gpio-dwapb: Enable platform driver binding
 to MFD driver

On Thu, 11 Sep 2014, Chen, Alvin wrote:

> > >
> > > Hi Alvin,
> > >
> > > I did a quick test and this looks like it works for me (with device tree).
> > > I had a couple of small fixes below.
> > It is very appreciated to help testing.

Sure.  Thanks for adding features to the driver!

> > 
> > 
> > > Alan
> > >
> > > >
> > > > -	port->bgc.gc.ngpio = ngpio;
> > > > -	port->bgc.gc.of_node = port_np;
> > > > +#ifdef CONFIG_OF_GPIO
> > > > +	port->bgc.gc.of_node = pp->node;
> > > > +#endif
> > >
> > > Please use 'if (IS_ENABLED(CONFIG_OF_GPIO)) as a conditional as you do
> > > elsewhere.
> > OK.
> > 
> Alan, I just do a quick test, here we can't use 'IS_ENABLED', it can't be compiled without OF_GPIO set.
> Because 'gc.of_node' is not defined without 'OF_GPIO'. You can refer the structure of 'gc'.
> 

That makes sense.

Thanks,
Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/