linux-kernel - Re: [PATCH v2 1/3] init/main.c: Give init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140911072345.012f4ef3@as>
Date:	Thu, 11 Sep 2014 07:23:45 -0500
From:	Chuck Ebbert <cebbert.lkml@...il.com>
To:	Aaron Tomlin <atomlin@...hat.com>
Cc:	peterz@...radead.org, mingo@...hat.com, dzickus@...hat.com,
	bmr@...hat.com, jcastillo@...hat.com, oleg@...hat.com,
	pzijlstr@...hat.com, riel@...hat.com, prarit@...hat.com,
	jgh@...hat.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	x86@...nel.org, rostedt@...dmis.org, hannes@...xchg.org,
	aneesh.kumar@...ux.vnet.ibm.com, akpm@...ux-foundation.org,
	akpm@...gle.com, linuxppc-dev@...ts.ozlabs.org, minchan@...nel.org
Subject: Re: [PATCH v2 1/3] init/main.c: Give init_task a canary

On Wed, 10 Sep 2014 14:29:33 +0100
Aaron Tomlin <atomlin@...hat.com> wrote:

> On Wed, Sep 10, 2014 at 02:26:54AM -0500, Chuck Ebbert wrote:
> > And has this been tested on parisc and metag, which use STACK_GROWSUP ?
> > I can't see how end_of_stack() as it's defined now could work on those archs.
> 
> AFAIU, dup_task_struct() has always done this explicitly.
> I see no reason why init_task requires special attention.
> 

I guess what I'm saying is, I can't see how the stack canary could have ever
detected any problems on parisc and metag. How did you test your patches on x86?
Maybe someone could run tests on those other archs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/