linux-kernel - Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140912083627.GX6600@mwanda>
Date:	Fri, 12 Sep 2014 11:36:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	micky_ching@...lsil.com.cn
Cc:	sameo@...ux.intel.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, wei_wang@...lsil.com.cn,
	devel@...uxdriverproject.org, rogerable@...ltek.com,
	lee.jones@...aro.org
Subject: Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227

On Thu, Sep 11, 2014 at 10:42:49AM +0300, Dan Carpenter wrote:
> On Thu, Sep 11, 2014 at 03:17:52PM +0800, micky_ching@...lsil.com.cn wrote:
> > +	err = pci_read_config_byte(pcr->pci, addr, &val);
> > +	if (err)
> > +		return err;
> 
> Some of these check for "if (err) " and some check for "if (err < 0) ".
> What is the significance of that?  I'm a newbie here.  Did you mean for
> them to be different?

You've updated them all to be "if (err < 0)" how is that different from
"if (err)"?  What I'm saying is that could you reply to the question?

I guess I normally prefer "if (err)" over "if (err < 0)" but I don't
know if it makes a difference here?

regards,
dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/