linux-kernel - Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Sep 2014 16:43:06 +0800
From:	micky <micky_ching@...lsil.com.cn>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	<sameo@...ux.intel.com>, <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <wei_wang@...lsil.com.cn>,
	<devel@...uxdriverproject.org>, <rogerable@...ltek.com>,
	<lee.jones@...aro.org>
Subject: Re: [PATCH 1/2] mfd: rtsx: fix PM suspend for 5227

On 09/12/2014 04:36 PM, Dan Carpenter wrote:
> You've updated them all to be "if (err < 0)" how is that different from
> "if (err)"?  What I'm saying is that could you reply to the question?
>
> I guess I normally prefer "if (err)" over "if (err < 0)" but I don't
> know if it makes a difference here?
Hi Dan,

these function never return positive value, but other part of the driver 
code
use (err < 0), I use (err < 0) here for consistency.

(err) and (err < 0) is same at least for these function called here.

Best Regards.
micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/