linux-kernel - Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5412BE19.2010302@ti.com>
Date:	Fri, 12 Sep 2014 12:34:17 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Xiubo Li <Li.Xiubo@...escale.com>
CC:	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<plagnioj@...osoft.com>, <grant.likely@...aro.org>,
	<arnd@...db.de>, <peter.griffin@...aro.org>, <jg1.han@...sung.com>,
	<daniel.vetter@...ll.ch>, <laurent.pinchart@...asonboard.com>,
	<robdclark@...il.com>, <linux-fbdev@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs

Hi,

On 05/09/14 07:48, Xiubo Li wrote:
> Some Freescale SoCs, there has an DVI/HDMI controller and a PHY,
> attached to one of their display controller unit's LCDC interfaces.
> This patch adds a preliminary static support for such controllers.
> 
> This will support for many modes and a dynamic switching between
> them.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com>
> ---
>  .../devicetree/bindings/video/fsl-sii902x.txt      |  17 +
>  drivers/video/fbdev/Kconfig                        |   7 +
>  drivers/video/fbdev/Makefile                       |   1 +
>  drivers/video/fbdev/fsl-sii902x.c                  | 526 +++++++++++++++++++++
>  4 files changed, 551 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/video/fsl-sii902x.txt
>  create mode 100644 drivers/video/fbdev/fsl-sii902x.c

I don't know how you picked the names of the people you sent this patch
to, but looks to me that most of them are probably not interested in
this patch.

Anyway, a few quick comments on the patch:

- You should probably use regmap instead of direct i2c calls.
Interestingly, you define regmap variable, but you never use it.
- Use defines for register offsets, instead of magic numbers.
- You should not use static variables. They prevent having multiple
instances of the device.

So the SiI902x chip is on the SoC, not on the board? And it's a plain
standard SiI902x in other aspects?

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)