lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 02:17:24 +0000 From: "Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com> To: Tomi Valkeinen <tomi.valkeinen@...com> CC: "robh+dt@...nel.org" <robh+dt@...nel.org>, "pawel.moll@....com" <pawel.moll@....com>, "mark.rutland@....com" <mark.rutland@....com>, "ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>, "galak@...eaurora.org" <galak@...eaurora.org>, "plagnioj@...osoft.com" <plagnioj@...osoft.com>, "grant.likely@...aro.org" <grant.likely@...aro.org>, "arnd@...db.de" <arnd@...db.de>, "peter.griffin@...aro.org" <peter.griffin@...aro.org>, "jg1.han@...sung.com" <jg1.han@...sung.com>, "daniel.vetter@...ll.ch" <daniel.vetter@...ll.ch>, "laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>, "robdclark@...il.com" <robdclark@...il.com>, "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs Hi Tomi, Thanks very much for your comments. > Subject: Re: [PATCH] fbdev: fsl-sii902x: HDMI support for Freescale SoCs > > Hi, > > On 05/09/14 07:48, Xiubo Li wrote: > > Some Freescale SoCs, there has an DVI/HDMI controller and a PHY, > > attached to one of their display controller unit's LCDC interfaces. > > This patch adds a preliminary static support for such controllers. > > > > This will support for many modes and a dynamic switching between > > them. > > > > Signed-off-by: Xiubo Li <Li.Xiubo@...escale.com> > > --- > > .../devicetree/bindings/video/fsl-sii902x.txt | 17 + > > drivers/video/fbdev/Kconfig | 7 + > > drivers/video/fbdev/Makefile | 1 + > > drivers/video/fbdev/fsl-sii902x.c | 526 > +++++++++++++++++++++ > > 4 files changed, 551 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/video/fsl-sii902x.txt > > create mode 100644 drivers/video/fbdev/fsl-sii902x.c > > I don't know how you picked the names of the people you sent this patch > to, but looks to me that most of them are probably not interested in > this patch. > I just using the get_maintainer.pl script. > Anyway, a few quick comments on the patch: > > - You should probably use regmap instead of direct i2c calls. > Interestingly, you define regmap variable, but you never use it. Yes, this it's my another version in my local machine using regmap which need much more test. > - Use defines for register offsets, instead of magic numbers. This will be fixed together with regmap using. > - You should not use static variables. They prevent having multiple > instances of the device. > Okay. > So the SiI902x chip is on the SoC, not on the board? And it's a plain > standard SiI902x in other aspects? > No, it's on board. And it will be used for i.MX and LS1+ platforms. Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists