lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 12 Sep 2014 18:08:19 +0200
From:	Bartlomiej Zolnierkiewicz <>
Subject: Re: [PATCHv4 03/12] usb: dwc2: Update the gadget driver to use common
 dwc2_hsotg structure

[ added linux-kernel ML to cc: ]


On Tuesday, August 26, 2014 11:19:54 AM wrote:
> From: Dinh Nguyen <>
> Adds the gadget data structure and appropriate data structure pointers
> to the common dwc2_hsotg data structure. To keep the driver data
> dereference code looking clean, the gadget variable declares are only available
> for peripheral and dual-role mode. This is needed so that the dwc2_hsotg data
> structure can be used by the hcd and gadget drivers.
> Updates gadget.c to use the dwc2_hsotg data structure and gadget pointers
> that have been moved into the common dwc2_hsotg structure. Along
> with the updating the gadget driver to use the common dwc2_hsotg structure,
> a few other things are required in order for this patch to build properly.
> Those are:
> - Remove gadget module defines. Since the driver probing will be handled
>   by either the platform or pci code.

Removal of gadget module defines should be done in the same patch that
adds gadget functionality probing to platform/PCI new common code.

> - Change the gadget probe function into gadget_init.
> Signed-off-by: Dinh Nguyen <>
> Signed-off-by: Paul Zimmerman <>
> ---
> v3: Updated with paulz's suggestion to avoid double pointers.
> v2: Left the function parameter name as 'hsotg' and just changed its type.
> ---
>  drivers/usb/dwc2/core.h   | 176 +++++++++++++++++++++---------------
>  drivers/usb/dwc2/gadget.c | 226 +++++++++++++++++-----------------------------
>  drivers/usb/dwc2/hcd.h    |  10 --
>  3 files changed, 184 insertions(+), 228 deletions(-)

Best regards,
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists