linux-kernel - RE: [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1409121045070.373@atx-linux-37>
Date:	Fri, 12 Sep 2014 10:46:54 -0500
From:	atull <atull@...nsource.altera.com>
To:	"Chen, Alvin" <alvin.chen@...el.com>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	"Westerberg, Mika" <mika.westerberg@...el.com>,
	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: RE: [PATCH 4/4 v3] GPIO: gpio-dwapb: Suspend & Resume PM enabling

On Fri, 12 Sep 2014, Chen, Alvin wrote:

> > On Tue, 9 Sep 2014, Weike Chen wrote:
> > 
> > >
> > >  struct dwapb_gpio;
> > > +struct dwapb_context;
> > >
> > >  struct dwapb_gpio_port {
> > >  	struct bgpio_chip	bgc;
> > >  	bool			is_registered;
> > >  	struct dwapb_gpio	*gpio;
> > > +	struct dwapb_context	*ctx;
> > 
> > Alvin,
> > 
> > Will this build if CONFIG_PM_SLEEP is not defined?
> Actually, PM_SLEEP is always set as 'y' in 'kerne/power/Kconfig'. But I manually change it to 'n', this module can be compiled correctly.
> You may be concern with 'ctx', and you can see 'ctx' accessing is always in CONFIG_PM_SLEEP.

Yes and in the case of 'struct dwapb_context *ctx;' it is ok for struct 
dwapb_context to be an incomplete type since that's just a pointer.

Alan 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/