linux-kernel - Re: [PATCH v3 3/3] sched: BUG when stack end location is over written

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1410494817.17540.4.camel@concordia>
Date:	Fri, 12 Sep 2014 14:06:57 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Aaron Tomlin <atomlin@...hat.com>
Cc:	peterz@...radead.org, dzickus@...hat.com, jcastillo@...hat.com,
	riel@...hat.com, x86@...nel.org, akpm@...ux-foundation.org,
	minchan@...nel.org, mingo@...nel.com, bmr@...hat.com,
	prarit@...hat.com, oleg@...hat.com, rostedt@...dmis.org,
	linux-kernel@...r.kernel.org, hannes@...xchg.org, mingo@...hat.com,
	aneesh.kumar@...ux.vnet.ibm.com, akpm@...gle.com, jgh@...hat.com,
	linuxppc-dev@...ts.ozlabs.org, tglx@...utronix.de,
	pzijlstr@...hat.com
Subject: Re: [PATCH v3 3/3] sched: BUG when stack end location is over
 written

On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote:
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index a285900..2a8280a 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -824,6 +824,18 @@ config SCHEDSTATS
>  	  application, you can say N to avoid the very slight overhead
>  	  this adds.
>  
> +config SCHED_STACK_END_CHECK
> +	bool "Detect stack corruption on calls to schedule()"
> +	depends on DEBUG_KERNEL
> +	default y

Did you really mean default y?

Doing so means it will be turned on more or less everywhere, which defeats the
purpose of having a config option in the first place.

> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index ec1a286..0b70b73 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2660,6 +2660,9 @@ static noinline void __schedule_bug(struct task_struct *prev)
>   */
>  static inline void schedule_debug(struct task_struct *prev)
>  {
> +#ifdef CONFIG_SCHED_STACK_END_CHECK
> +	BUG_ON(unlikely(task_stack_end_corrupted(prev)))
> +#endif

If this was my code I'd make you put that in a static inline.

cheers



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/