lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 16 Sep 2014 06:49:45 +0800
From:	Chen Gang <>
To:	David Vrabel <>
	"" <>
Subject: Re: [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove
 redundancy asignment to 'addr'

On 09/15/2014 11:41 PM, David Vrabel wrote:
> On 14/09/14 11:49, Chen Gang wrote:
>> When failure occurs, 'node' is already set to NULL, and it is enough
>> for next checking (which will return in time), so need not set 'addr'.
> I'm not going to apply this one.  The redundant assignment is harmless
> and improve clarity slightly, IMO.

Hmm... maybe, it may depend on personal hobby, for me, only focusing one
'control' value (in our case is 'node') is more clearer than focusing
two 'control' values ('node' and 'addr').

In kernel conding styles, I feel (but I have no any proofs for it), it
is focus on performance, if one value need not be assigned, it need be

But all together, I need respect the related maintainer's taste, if
he/she sticks to his/her taste.

Chen Gang

Open share and attitude like air water and life which God blessed
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists