lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 16:41:15 +0100 From: David Vrabel <david.vrabel@...rix.com> To: Chen Gang <gang.chen.5i5j@...il.com>, <konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>, David Vrabel <david.vrabel@...rix.com>, <stefano.stabellini@...citrix.com>, <mukesh.rathor@...cle.com> CC: <xen-devel@...ts.xenproject.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [Xen-devel] [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr' On 14/09/14 11:49, Chen Gang wrote: > When failure occurs, 'node' is already set to NULL, and it is enough > for next checking (which will return in time), so need not set 'addr'. I'm not going to apply this one. The redundant assignment is harmless and improve clarity slightly, IMO. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists