lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 10:24:56 +0100 From: Catalin Marinas <catalin.marinas@....com> To: Grant Likely <grant.likely@...retlab.ca> Cc: "graeme.gregory@...aro.org" <graeme.gregory@...aro.org>, Arnd Bergmann <arnd@...db.de>, "linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>, Rob Herring <robh@...nel.org>, Randy Dunlap <rdunlap@...radead.org>, Robert Richter <rric@...nel.org>, Jason Cooper <jason@...edaemon.net>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, Marc Zyngier <Marc.Zyngier@....com>, Daniel Lezcano <daniel.lezcano@...aro.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Robert Moore <robert.moore@...el.com>, Will Deacon <Will.Deacon@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mark Brown <broonie@...nel.org>, Olof Johansson <olof@...om.net>, Liviu Dudau <Liviu.Dudau@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Lv Zheng <lv.zheng@...el.com> Subject: Re: [Linaro-acpi] [RFC PATCH for Juno 1/2] net: smsc911x add support for probing from ACPI On Mon, Sep 15, 2014 at 05:08:44AM +0100, Grant Likely wrote: > On Mon, 1 Sep 2014 16:28:54 +0100, Graeme Gregory <graeme.gregory@...aro.org> wrote: > > On Mon, Sep 01, 2014 at 05:17:51PM +0200, Arnd Bergmann wrote: > > > On Monday 01 September 2014 23:06:00 Hanjun Guo wrote: > > > > +#ifdef CONFIG_ACPI > > > > +/* Configure some sensible defaults for ACPI mode */ > > > > +static int smsc911x_probe_config_acpi(struct smsc911x_platform_config *config, > > > > + acpi_handle *ahandle) > > > > +{ > > > > + if (!ahandle) > > > > + return -ENOSYS; > > > > + > > > > + config->phy_interface = PHY_INTERFACE_MODE_MII; > > > > > > > > > > Please remove the #ifdef and use > > > > > > if (!IS_ENABLED(CONFIG_ACPI) || !ahandle) > > > > > > to check for ACPI support. This should result in the same object code > > > in all cases, but give better compile-time coverage when ACPI is > > > disabled. > > > > > struct acpi_handle does not exist in the case !CONFIG_ACPI > > > > > Also, -ENOSYS is probably the wrong return value. I think you mean > > > -ENXIO. > > > > > Yes that would make sense thanks. > > > > Not sure if we are planning to actually upstream this patch, I guess it > > depends if ARM start shipping Junos with the ACPI tables loaded on them. > > I think we do want this upstreamed. Juno is intended to be a readily > available reference platform, regardless of the firmware loaded when > shipped. There will be users who use it as a test platform for ACPI > development. The patches for Juno are not intrusive. The only problem I have is giving the wrong example on how to deal with the platform-specific device information like this patch. I would much prefer to use _DSD (once we agree on how to do this) than hard-coding information based on the ACPI device id (you would need one for each SoC). I don't think we have reached an agreement yet: https://lkml.kernel.org/g/4816592.tj3on6vUaC@wuerfel -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists