lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 15 Sep 2014 17:16:17 +0300
From:	Stanimir Varbanov <>
To:	Hartmut Knaack <>
CC:	Ian Campbell <>,
	Pawel Moll <>,
	Rob Herring <>,
	Kumar Gala <>,
	Mark Rutland <>,
	Grant Likely <>,
	Jonathan Cameron <>,
	Arnd Bergmann <>,,,,,
	Greg Kroah-Hartman <>,
	Lars-Peter Clausen <>,
	Angelo Compagnucci <>,
	Doug Anderson <>,
	Fugang Duan <>,
	Johannes Thumshirn <>,
	Jean Delvare <>,
	Philippe Reynes <>,
	Lee Jones <>,
	Josh Cartwright <>,
	Stephen Boyd <>,
	David Collins <>,
	"Ivan T. Ivanov" <>
Subject: Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

Thanks for the comments!

On 09/13/2014 02:27 AM, Hartmut Knaack wrote:
> Stanimir Varbanov schrieb, Am 11.09.2014 17:13:
>> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has
>> 15bits resolution and register space inside PMIC accessible across
>> SPMI bus.
>> The vadc driver registers itself through IIO interface.
> Looks already pretty good. Things you should consider in regard of common coding style are to use the variable name ret instead of rc, since it is used in almost all adc drivers and thus makes reviewing a bit easier. Besides that, you seem to use unsigned as well as unsigned int, so to be consistent, please stick to one of them. Other comments in line.

OK, I will take into account your comments.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists