lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 17:16:17 +0300 From: Stanimir Varbanov <svarbanov@...sol.com> To: Hartmut Knaack <knaack.h@....de> CC: Ian Campbell <ijc+devicetree@...lion.org.uk>, Pawel Moll <pawel.moll@....com>, Rob Herring <robh+dt@...nel.org>, Kumar Gala <galak@...eaurora.org>, Mark Rutland <mark.rutland@....com>, Grant Likely <grant.likely@...aro.org>, Jonathan Cameron <jic23@...nel.org>, Arnd Bergmann <arnd@...db.de>, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, devicetree@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Lars-Peter Clausen <lars@...afoo.de>, Angelo Compagnucci <angelo.compagnucci@...il.com>, Doug Anderson <dianders@...omium.org>, Fugang Duan <B38611@...escale.com>, Johannes Thumshirn <johannes.thumshirn@....de>, Jean Delvare <jdelvare@...e.de>, Philippe Reynes <tremyfr@...oo.fr>, Lee Jones <lee.jones@...aro.org>, Josh Cartwright <joshc@...eaurora.org>, Stephen Boyd <sboyd@...eaurora.org>, David Collins <collinsd@...eaurora.org>, "Ivan T. Ivanov" <iivanov@...sol.com> Subject: Re: [PATCH v2 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver Thanks for the comments! On 09/13/2014 02:27 AM, Hartmut Knaack wrote: > Stanimir Varbanov schrieb, Am 11.09.2014 17:13: >> The voltage ADC is peripheral of Qualcomm SPMI PMIC chips. It has >> 15bits resolution and register space inside PMIC accessible across >> SPMI bus. >> >> The vadc driver registers itself through IIO interface. >> > Looks already pretty good. Things you should consider in regard of common coding style are to use the variable name ret instead of rc, since it is used in almost all adc drivers and thus makes reviewing a bit easier. Besides that, you seem to use unsigned as well as unsigned int, so to be consistent, please stick to one of them. Other comments in line. OK, I will take into account your comments. <snip> -- regards, Stan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists