linux-kernel - Re: [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 07:21:46 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Behan Webster <behanw@...verseincode.com>
Cc:	Alasdair G Kergon <agk@...hat.com>, Chris Mason <clm@...com>,
	David Miller <davem@...emloft.net>,
	"dm-devel@...hat.com" <dm-devel@...hat.com>,
	Fabian Frederick <fabf@...net.be>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Josef Bacik <jbacik@...com>, Mike Snitzer <snitzer@...hat.com>,
	tadeusz.struk@...el.com, Andrew Morton <akpm@...ux-foundation.org>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Dmitry Kasatkin <d.kasatkin@...sung.com>,
	James Morris <james.l.morris@...cle.com>,
	john.griffin@...el.com, linux-btrfs <linux-btrfs@...r.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	linux-ima-devel@...ts.sourceforge.net,
	linux-ima-user@...ts.sourceforge.net,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
	LSM List <linux-security-module@...r.kernel.org>,
	Neil Brown <neilb@...e.de>, qat-linux@...el.com,
	"Serge E. Hallyn" <serge@...lyn.com>, thomas.lendacky@....com,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c

On Mon, Sep 15, 2014 at 12:30 AM,  <behanw@...verseincode.com> wrote:
> From: Behan Webster <behanw@...verseincode.com>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This patch allocates the appropriate amount of memory
> using a char array using the SHASH_DESC_ON_STACK macro.

You only made the first case use SHASH_DESC_ON_STACK, the two other
cases you left in the ugly format. Was that just an oversight, or was
there some reason for it?

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/