lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 16:27:53 +0100 From: David Vrabel <david.vrabel@...rix.com> To: Chen Gang <gang.chen.5i5j@...il.com>, <konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>, David Vrabel <david.vrabel@...rix.com>, <stefano.stabellini@...citrix.com>, <mukesh.rathor@...cle.com> CC: <xen-devel@...ts.xenproject.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [Xen-devel] [PATCH 2/4] drivers/xen/xenbus/xenbus_client.c: Correct the comments for xenbus_grant_ring() On 14/09/14 11:50, Chen Gang wrote: > Both zero and positive number can indicate success, so the original > comments need be improved. > > Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com> > --- > drivers/xen/xenbus/xenbus_client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c > index 277e74d..e2cf681 100644 > --- a/drivers/xen/xenbus/xenbus_client.c > +++ b/drivers/xen/xenbus/xenbus_client.c > @@ -361,8 +361,8 @@ static void xenbus_switch_fatal(struct xenbus_device *dev, int depth, int err, > * @ring_mfn: mfn of ring to grant > > * Grant access to the given @ring_mfn to the peer of the given device. Return > - * 0 on success, or -errno on error. On error, the device will switch to > - * XenbusStateClosing, and the error will be saved in the store. > + * 0 or positive number on success, or -errno on error. On error, the device > + * will switch to XenbusStateClosing, and the error will be saved in the store. If you're going to update this comment, please state what it is actually returning: i.e., a grant reference or -ve on error. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists