lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Sep 2014 11:01:40 -0700 From: Olof Johansson <olof@...om.net> To: Grant Likely <grant.likely@...aro.org> Cc: Hanjun Guo <hanjun.guo@...aro.org>, Catalin Marinas <catalin.marinas@....com>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Mark Rutland <mark.rutland@....com>, Will Deacon <will.deacon@....com>, Graeme Gregory <graeme.gregory@...aro.org>, Arnd Bergmann <arnd@...db.de>, Sudeep Holla <Sudeep.Holla@....com>, Jon Masters <jcm@...hat.com>, Jason Cooper <jason@...edaemon.net>, Marc Zyngier <marc.zyngier@....com>, Bjorn Helgaas <bhelgaas@...gle.com>, Daniel Lezcano <daniel.lezcano@...aro.org>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, Robert Richter <rric@...nel.org>, Lv Zheng <lv.zheng@...el.com>, Robert Moore <robert.moore@...el.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>, Liviu Dudau <Liviu.Dudau@....com>, Randy Dunlap <rdunlap@...radead.org>, Charles Garcia-Tobin <Charles.Garcia-Tobin@....com>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>, Tomasz Nowicki <tomasz.nowicki@...aro.org> Subject: Re: [PATCH v4 10/18] ACPI / table: Print GIC information when MADT is parsed On Mon, Sep 15, 2014 at 10:52 AM, Grant Likely <grant.likely@...aro.org> wrote: > On Sun, 14 Sep 2014 23:40:10 -0700, Olof Johansson <olof@...om.net> wrote: >> On Fri, Sep 12, 2014 at 10:00:08PM +0800, Hanjun Guo wrote: >> > When MADT is parsed, print GIC information to make the boot >> > log look pretty. >> >> If you do this for prettiness, having an example output in the commit >> message would be a nice touch. > > Agreed. > >> The question is why it's needed though? Do we really need all this verbose >> information in dmesg when it could be found out in other ways instead? >> >> x86 is notoriously verbose in some of these aspects, I'm not sure it's >> something we need to mimic here? > > For consistency, it does make sense to have the common x86 and ARM64 > code outputing information in the same way, so I think the patch still > makes sense. All of them could be moved to KERN_DEBUG as a separate > patch if we want to cull early boot output. I would split that off and > discuss it separately. Yeah, pr_debug() makes sense here -- in particular if you're going to have a potentially slow serial console to print all this to at info level. I disagree on order though, there's no reason to hold off fixing this and doing it as a separate patch. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists