linux-kernel - Re: [PATCH 3.14 039/114] scsi: add a blacklist flag which enables VPD page inquiries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 15 Sep 2014 22:23:42 +0100
From:	Sitsofe Wheeler <sitsofe@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	KY Srinivasan <kys@...rosoft.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@....de>,
	James Bottomley <James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH 3.14 039/114] scsi: add a blacklist flag which enables
 VPD page inquiries

On Mon, Sep 15, 2014 at 12:25:39PM -0700, Greg Kroah-Hartman wrote:
> 3.14-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: "Martin K. Petersen" <martin.petersen@...cle.com>
> 
> commit c1d40a527e885a40bb9ea6c46a1b1145d42b66a0 upstream.
> 
> Despite supporting modern SCSI features some storage devices continue to
> claim conformance to an older version of the SPC spec. This is done for
> compatibility with legacy operating systems.
> 
> Linux by default will not attempt to read VPD pages on devices that
> claim SPC-2 or older. Introduce a blacklist flag that can be used to
> trigger VPD page inquiries on devices that are known to support them.
> 
> Reported-by: KY Srinivasan <kys@...rosoft.com>
> Tested-by: KY Srinivasan <kys@...rosoft.com>
> Reviewed-by: KY Srinivasan <kys@...rosoft.com>
> Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---

<snip>

> +#define BLIST_TRY_VPD_PAGES	0x10000000 /* Attempt to read VPD pages */
>  #endif

Where is BLIST_TRY_VPD_PAGES being quirked on for Hyper-V's devices - is
there some later patch or some missing code I'm overlooking?

If the missing piece is f3cfabce7a2e92564d380de3aad4b43901fb7ae6, are
people sure it works? I'll retest but the last two times I tested it
(https://lkml.org/lkml/2014/7/23/615 and
https://lkml.org/lkml/2014/8/1/460 ) no one said anything after I said
thin provisioning wasn't enabled and James doesn't like quirking this on
every Hyper-V device (https://lkml.org/lkml/2014/7/24/393 )...

-- 
Sitsofe | http://sucs.org/~sits/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/