lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Sep 2014 09:00:50 +0200 From: Ingo Molnar <mingo@...nel.org> To: Stephane Eranian <eranian@...gle.com> Cc: linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu, ak@...ux.intel.com, kan.liang@...el.com Subject: Re: [PATCH] perf/x86/uncore: update support for client uncore IMC PMU * Stephane Eranian <eranian@...gle.com> wrote: > > This patch restructures the memory controller (IMC) uncore > PMU support for client SNB/IVB/HSW processors. The main change > is that it can now cope with more than one PCI device ID per > processor model. There are many flavors of memory controllers > for each processor. They have different PCI device ID, yet > they behave the same w.r.t. the memory controller PMU that > we are interested in. > > The patch now supports two distinct memory controllers for IVB > processors: one for mobile, one for desktop. > > Signed-off-by: Stephane eranian <eranian@...gle.com> > --- > arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c | 68 +++++++++++++++------ > include/linux/pci_ids.h | 1 + > 2 files changed, 51 insertions(+), 18 deletions(-) Please run patches through scripts/checkpatch.pl before submission, in case it points out legit problems. Checkpatch emits 6 warnings for your patch, the first four are bogus, the last two are worth addressing: WARNING: space prohibited between function name and open parenthesis '(' #77: FILE: arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c:517: + for_each_imc_pci_id (p, desktop_imc_pci_ids) { WARNING: Missing a blank line after declarations #92: FILE: arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c:528: + struct pci_driver *imc_drv = imc_uncore_find_dev(); + if (!imc_drv) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists