linux-kernel - Re: [PATCH v5 07/12] usb: chipidea: add a usb2 driver for ci13xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140916140551.GE4869@kwain>
Date:	Tue, 16 Sep 2014 16:05:51 +0200
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Peter Chen <peter.chen@...escale.com>
Cc:	Antoine Tenart <antoine.tenart@...e-electrons.com>,
	sebastian.hesselbarth@...il.com, balbi@...com,
	p.zabel@...gutronix.de, alexandre.belloni@...e-electrons.com,
	thomas.petazzoni@...e-electrons.com, zmxu@...vell.com,
	jszhang@...vell.com, linux-arm-kernel@...ts.infradead.org,
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 07/12] usb: chipidea: add a usb2 driver for ci13xxx

On Tue, Sep 16, 2014 at 03:38:41PM +0200, Antoine Tenart wrote:
> On Tue, Sep 16, 2014 at 08:51:30AM +0800, Peter Chen wrote:
> > On Mon, Sep 15, 2014 at 12:36:13PM +0200, Antoine Tenart wrote:
> > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock
> > > and DMA mask, to support USB2 ChipIdea controllers that don't need
> > > specific functions.
> > > 
> > > Tested on the Marvell Berlin SoCs USB controllers.
> > > 
> > > Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>
> > > ---
> > >  drivers/usb/chipidea/Makefile       |   1 +
> > >  drivers/usb/chipidea/ci_hdrc_usb2.c | 137 ++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 138 insertions(+)
> > >  create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c
> > > 
> > 
> > compile error:
> > 
> > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c: In function 'ci_hdrc_usb2_dt_probe':
> > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30:2: error: implicit declaration of function 'of_phy_get' [-Werror=implicit-function-declaration]
> > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30:16: warning: assignment makes pointer from integer without a cast [enabled by default]
> 
> Did you apply the series introducing the support for the generic PHY
> framework in the USB subsystem first? One of the patches includes
> 'linux/phy/phy.h' in 'linux/usb/otg.h'. That's why I did not encounter
> this error.
> 
> Anyway, you're right and 'linux/phy/phy.h' should be explicitly included
> here.

Let me know if you want me to quickly cook up a new version fixing this.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/