linux-kernel - RE: [PATCH v5 07/12] usb: chipidea: add a usb2 driver for ci13xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 17 Sep 2014 00:00:57 +0000
From:	Peter Chen <Peter.Chen@...escale.com>
To:	Antoine Tenart <antoine.tenart@...e-electrons.com>
CC:	"sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>,
	"balbi@...com" <balbi@...com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"alexandre.belloni@...e-electrons.com" 
	<alexandre.belloni@...e-electrons.com>,
	"thomas.petazzoni@...e-electrons.com" 
	<thomas.petazzoni@...e-electrons.com>,
	"zmxu@...vell.com" <zmxu@...vell.com>,
	"jszhang@...vell.com" <jszhang@...vell.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v5 07/12] usb: chipidea: add a usb2 driver for ci13xxx

 
> > > > Tested on the Marvell Berlin SoCs USB controllers.
> > > >
> > > > Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>
> > > > ---
> > > >  drivers/usb/chipidea/Makefile       |   1 +
> > > >  drivers/usb/chipidea/ci_hdrc_usb2.c | 137
> > > > ++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 138 insertions(+)  create mode 100644
> > > > drivers/usb/chipidea/ci_hdrc_usb2.c
> > > >
> > >
> > > compile error:
> > >
> > > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c: In
> function 'ci_hdrc_usb2_dt_probe':
> > > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30
> > > :2: error: implicit declaration of function 'of_phy_get'
> > > [-Werror=implicit-function-declaration]
> > > /home/peter/work/projects/usb/drivers/usb/chipidea/ci_hdrc_usb2.c:30
> > > :16: warning: assignment makes pointer from integer without a cast
> > > [enabled by default]
> >
> > Did you apply the series introducing the support for the generic PHY
> > framework in the USB subsystem first? One of the patches includes
> > 'linux/phy/phy.h' in 'linux/usb/otg.h'. That's why I did not encounter
> > this error.
> >
> > Anyway, you're right and 'linux/phy/phy.h' should be explicitly
> > included here.
> 
> Let me know if you want me to quickly cook up a new version fixing this.
> 

You can send this fix if you don't want to get comments for other parts in this
series.

I also see other dependencies like generic phy support for chipidea with this one.
I think the 7th and 8th in this series are ok after adding 'linux/phy/phy.h', but
you generic phy support series should be queued before this one.

Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/