lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 16 Sep 2014 18:39:51 +0100
From:	Al Viro <>
To:	James Hogan <>
Cc:	Linus Torvalds <>,,
	Geert Uytterhoeven <>,,
Subject: Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()

On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote:
> Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of
> link_path_walk()) introduced build problems with GCC versions older than
> 4.6 due to the initialisation of a member of an anonymous union in
> struct qstr without enclosing braces.
> This hits GCC bug 10676 [1] (which was fixed in GCC 4.6 by [2]), and
> causes the following build error:
>   fs/namei.c: In function 'link_path_walk':
>   fs/namei.c:1778: error: unknown field 'hash_len' specified in initializer
> This is worked around by adding explicit braces.

IOW, the same thing QSTR_INIT is doing...  BTW, after looking at the commit
in question, what the hell was this
+                               name =;
in link_path_walk() about?  Granted, none of the ->d_hash() instances in
the tree reassign qstr->name, and out-of-tree ones are unlikely to do it
either, so it's harmless but... why bother rereading at all?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists