linux-kernel - Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54199515.6000402@imgtec.com>
Date:	Wed, 17 Sep 2014 15:05:09 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-metag@...r.kernel.org>
Subject: Re: [PATCH] vfs: workaround gcc <4.6 build error in link_path_walk()

On 16/09/14 18:39, Al Viro wrote:
> On Tue, Sep 16, 2014 at 01:07:35PM +0100, James Hogan wrote:
>> Commit d6bb3e9075bb (vfs: simplify and shrink stack frame of
>> link_path_walk()) introduced build problems with GCC versions older than
>> 4.6 due to the initialisation of a member of an anonymous union in
>> struct qstr without enclosing braces.
>>
>> This hits GCC bug 10676 [1] (which was fixed in GCC 4.6 by [2]), and
>> causes the following build error:
>>   fs/namei.c: In function 'link_path_walk':
>>   fs/namei.c:1778: error: unknown field 'hash_len' specified in initializer
>>
>> This is worked around by adding explicit braces.
> 
> IOW, the same thing QSTR_INIT is doing...

QSTR_INIT only initialises len and name, not the hash.

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/