lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Sep 2014 23:40:37 +0200 From: Frans Klaver <fransklaver@...il.com> To: Darren Hart <dvhart@...radead.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Corentin Chary <corentin.chary@...il.com>, Rafael Wysocki <rafael.j.wysocki@...el.com>, acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>, platform-driver-x86 <platform-driver-x86@...r.kernel.org>, linux-kernel@...r.kernel.org, linux-acpi <linux-acpi@...r.kernel.org>, "H. Peter Anvin" <hpa@...ux.intel.com> Subject: Re: [PATCH 10/13] eeepc-laptop: compare proper return values in get_cpufv On Tue, Sep 16, 2014 at 02:27:15PM -0700, Darren Hart wrote: > > - When reading and writing sysfs device attribute files, avoid dependency > on specific error codes wherever possible. This minimizes coupling to > the error handling implemementation within the kernel. > > In general, failures to read or write sysfs device attributes shall > propogate errors wherever possible. Common errors include, but are not > limited to: > > -EIO: The read or store operation is not supported, typically returned by > the sysfs system itself if the read or store pointer is NULL. > > -ENXIO: The read or store operation failed > > Error codes will not be changed without good reason, and should a change > to error codes result in user-space breakage, it will be fixed, or the > the offending change will be reverted. sysfs-rules.txt is written for user space? In that case, reverting the change is as much a fix as patching it. > > Userspace applications can, however, expect the format and contents of > the attribute files to remain consistent in the absence of a version > attribute change in the context of a given attributes. ...attribute. That's it for the nit-picking. Frans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists