lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 16 Sep 2014 16:41:53 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	myungjoo.ham@...sung.com, Jean Delvare <jdelvare@...e.de>,
	 <cw00.choi@...sung.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] extcon: sm5502: Depend on I2C

On 09/16/14 16:39, MyungJoo Ham wrote:
>> The SM5502 chip is an I2C device so its drivers must depend on I2C.
>> Failing to do so results in build failures on kernels where I2C is
>> not enabled.
>>
>> Signed-off-by: Jean Delvare <jdelvare@...e.de>
>> Cc: Chanwoo Choi <cw00.choi@...sung.com>
> 
> Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Geert sent this same patch.  I sent this same patch.
What happened to those patches?


> 
>> ---
>>  drivers/extcon/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -72,6 +72,7 @@ config EXTCON_PALMAS
>>  
>>  config EXTCON_SM5502
>>  	tristate "SM5502 EXTCON support"
>> +	depends on I2C
>>  	select IRQ_DOMAIN
>>  	select REGMAP_I2C
>>  	select REGMAP_IRQ
>>
>> -- 
>> Jean Delvare
>> SUSE L3 Support


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists