linux-kernel - Re: [Xen-devel] [PATCH V2 3/3] xen: eliminate scalability issues from initial mapping setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5419B40B0200007800035B09@mail.emea.novell.com>
Date:	Wed, 17 Sep 2014 15:17:15 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"David Vrabel" <david.vrabel@...rix.com>
Cc:	"xen-devel" <xen-devel@...ts.xenproject.org>,
	<boris.ostrovsky@...cle.com>, <konrad.wilk@...cle.com>,
	"Juergen Gross" <JGross@...e.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH V2 3/3] xen: eliminate scalability
 issues from initial mapping setup

>>> On 17.09.14 at 16:07, <david.vrabel@...rix.com> wrote:
> On 17/09/14 05:12, Juergen Gross wrote:
>> +static void __init xen_cleanmfnmap(unsigned long vaddr)
>> +{
>> +	unsigned long va = vaddr & PMD_MASK;
>> +	unsigned long pa;
>> +	pgd_t *pgd = pgd_offset_k(va);
>> +	pud_t *pud_page = pud_offset(pgd, 0);
>> +	pud_t *pud;
>> +	pmd_t *pmd;
>> +	pte_t *pte;
>> +	unsigned int i;
>> +
>> +	set_pgd(pgd, __pgd(0));
>> +	do {
>> +		pud = pud_page + pud_index(va);
>> +		if (pud_none(*pud)) {
>> +			va += PUD_SIZE;
>> +		} else if (pud_large(*pud)) {
>> +			pa = pud_val(*pud) & PHYSICAL_PAGE_MASK;
>> +			xen_free_ro_pages(pa, PUD_SIZE);
>> +			va += PUD_SIZE;
> 
> Are you missing a ClearPagePinned(..) here?

No, this is a 1Gb data page, not a page table one.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/