lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 Sep 2014 02:26:14 +0100 From: Matthew Garrett <mjg59@...f.ucam.org> To: suravee.suthikulpanit@....com Cc: catalin.marinas@....com, will.deacon@....com, linux-arm-kernel@...ts.infradead.org, linux-acpi@...r.kernel.org, mark.rutland@....com, arnd@...db.de, graeme.gregory@...aro.org, marc.zyngier@....com, rjw@...ysocki.net, linux-kernel@...r.kernel.org, astone@...hat.com, grant.likely@...aro.org, hanjun.guo@...aro.org, Sudeep.Holla@....com, olof@...om.net, jason@...edaemon.net Subject: Re: [PATCH 1/4] ata: ahci_platform: Add ACPI support for AMD Seattle SATA controller On Mon, Sep 15, 2014 at 07:47:23PM -0500, suravee.suthikulpanit@....com wrote: > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com> > > This patch adds ACPI match table in ahci_platform. The table includes > the acpi_device_id to match AMD Seattle SATA controller with following > asl structure in DSDT: > > Device (SATA0) > { > Name(_HID, "AMDI0600") // Seattle AHSATA There really ought to be a well-defined PNPID for AHCI, so you can _HID to AMD and _CID to something generic. That way we won't have: > +#ifdef CONFIG_ATA_ACPI > +static const struct acpi_device_id ahci_acpi_match[] = { > + { "AMDI0600", 0 }, /* AMD Seattle AHCI */ > + { }, > +}; utter sadness here. Really, please don't end up in a situation where we need to add device-specific IDs to a generic driver. -- Matthew Garrett | mjg59@...f.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists