linux-kernel - Re: [PATCH v2 2/4] usb: hub: remove obsolete while cycle in hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1409171331280.1579-100000@iolanthe.rowland.org>
Date:	Wed, 17 Sep 2014 13:33:24 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Petr Mladek <pmladek@...e.cz>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tejun Heo <tj@...nel.org>,
	Joe Lawrence <joe.lawrence@...atus.com>,
	Jiri Kosina <jkosina@...e.cz>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/4] usb: hub: remove obsolete while cycle in hub_event()

On Wed, 17 Sep 2014, Petr Mladek wrote:

> The USB hub events are proceed by workqueue instead of kthread now.
> The result is that hub_event() function processes only one event.
> The block from the while cycle was not removed earlier to show the real
>  changes when switching to the workqueue.
> 
> When touching the code, it fixes also formatting of dev_err() and dev_dbg()
> calls to make checkpatch.pl happy :-)

More sylistic comments...

> +	hub = container_of(work, struct usb_hub, events);
> +	hdev = hub->hdev;
> +	hub_dev = hub->intfdev;
> +	intf = to_usb_interface(hub_dev);
> +
> +	dev_dbg(hub_dev, "state %d ports %d chg %04x evt %04x\n",
> +		hdev->state, hdev->maxchild,
> +		/* NOTE: expects max 15 ports... */
> +		(u16) hub->change_bits[0],
> +		(u16) hub->event_bits[0]);

In this file, continuation lines are indented by 2 tab stops beyond the 
starting line, not one.

> +		if (test_bit(i, hub->event_bits)
> +		    || test_bit(i, hub->change_bits)
> +		    || test_bit(i, hub->wakeup_bits)) {

And not four spaces.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/