linux-kernel - Re: [PATCH v2 4/4] usb: hub: rename khubd to hub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1409171333310.1579-100000@iolanthe.rowland.org>
Date:	Wed, 17 Sep 2014 13:36:26 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Petr Mladek <pmladek@...e.cz>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Tejun Heo <tj@...nel.org>,
	Joe Lawrence <joe.lawrence@...atus.com>,
	Jiri Kosina <jkosina@...e.cz>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] usb: hub: rename khubd to hub_wq in documentation
 and comments

On Wed, 17 Sep 2014, Petr Mladek wrote:

> USB hub has started to use a workqueue instead of kthread. Let's update
> the documentation and comments here and there.
> 
> This patch mostly just replaces "khubd" with "hub_wq". There are only few
> exceptions where the whole sentence was updated. These more complicated
> changes can be found in the following files:
> 
> 	   Documentation/usb/hotplug.txt
> 	   drivers/net/usb/usbnet.c
> 	   drivers/usb/core/hcd.c
> 	   drivers/usb/host/ohci-hcd.c
> 	   drivers/usb/host/xhci.c

Okay, here's a real issue.

> @@ -2042,7 +2042,7 @@ static void choose_devnum(struct usb_device *udev)
>  	int		devnum;
>  	struct usb_bus	*bus = udev->bus;
>  
> -	/* If khubd ever becomes multithreaded, this will need a lock */
> +	/* If hub_wq ever becomes multithreaded, this will need a lock */
>  	if (udev->wusb) {
>  		devnum = udev->portnum + 1;
>  		BUG_ON(test_bit(devnum, bus->devmap.devicemap));

You probably didn't notice when changing this comment.  But in fact,
workqueues _are_ multithreaded.  Therefore you need to add a lock to 
this routine.

Still, apart from these relatively minor issues, the series looks good.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/