lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Sep 2014 12:04:12 +0100 From: Matt Fleming <matt@...sole-pimps.org> To: Ricardo Neri <ricardo.neri-calderon@...ux.intel.com> Cc: Matt Fleming <matt.fleming@...el.com>, "H. Peter Anvin" <hpa@...ux.intel.com>, linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org, "Glenn P. Williamson" <glenn.p.williamson@...el.com> Subject: Re: [PATCH 2/6] x86/efi: use efi_memory_descriptor in convenience functions On Sat, 13 Sep, at 11:36:12AM, Ricardo Neri wrote: > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c > index 64ecbb5..29c85fe 100644 > --- a/drivers/firmware/efi/efi.c > +++ b/drivers/firmware/efi/efi.c > @@ -206,29 +206,23 @@ subsys_initcall(efisubsys_init); > */ > void __iomem *efi_lookup_mapped_addr(u64 phys_addr) > { > - struct efi_memory_map *map; > - void *p; > - map = efi.memmap; > - if (!map) > + efi_memory_desc_t *md; > + > + md = efi_memory_descriptor(phys_addr); Whoops. This change is causing the following build errors on ia64, /home/build/git/efi/arch/ia64/kernel/efi.c:722:1: error: static declaration of ‘efi_memory_descriptor’ follows non-static declaration efi_memory_descriptor (unsigned long phys_addr) ^ In file included from /home/build/git/efi/arch/ia64/kernel/efi.c:32:0: /home/build/git/efi/include/linux/efi.h:870:27: note: previous declaration of ‘efi_memory_descriptor’ was here extern efi_memory_desc_t *efi_memory_descriptor(unsigned long phys_addr); ^ and on arm64... drivers/built-in.o: In function `efi_lookup_mapped_addr': :(.text+0xb0e0): undefined reference to `efi_memory_descriptor' -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists